appDisplay: Fix folder loop in `_ensureDefaultFolders`

In testing on Fedora, gnome-shell crashes here:

JS ERROR: TypeError: DEFAULT_FOLDERS[folder] is undefined

This needs to be a "for of" loop, not a "for in" loop, because
`folders` is an array of the hash's keys, not the hash itself.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2238>

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index d8d0ff4f76795f339c37616b5ff2e04184aed070..821bfe3b8d41edaed446e0f573cf82f429e2d7cf 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1467,7 +1467,7 @@ class AppDisplay extends BaseAppView {
         this._folderSettings.set_strv('folder-children', folders);
 
         const { path } = this._folderSettings;
-        for (const folder in folders) {
+        for (const folder of folders) {
             const { name, categories, apps } = DEFAULT_FOLDERS[folder];
             const child = new Gio.Settings({
                 schema_id: 'org.gnome.desktop.app-folders.folder',